Re: [PATCH 0/3] Add JH7110 USB driver support

From: Conor Dooley
Date: Mon Mar 06 2023 - 05:24:14 EST


Hey Minda!

On Mon, Mar 06, 2023 at 05:52:12PM +0800, Minda Chen wrote:
> This patchset adds USB driver for the StarFive JH7110 SoC.
> USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board.
> The patch has been tested on the VisionFive 2 board.
>
> This patchset should be applied after the patchset [1] and patch [2]:
> [1] https://lore.kernel.org/all/20230221083323.302471-1-xingyu.wu@xxxxxxxxxxxxxxxx/
> [2] https://lore.kernel.org/all/20230215113249.47727-4-william.qiu@xxxxxxxxxxxxxxxx/
>
> patch 1 is usb phy dt-binding document.
> patch 2 is the glue layer of Cadence USB3 and USB phy
> setting. USB controller IP is Cadence USB3.
> patch 3 is USB device tree configuration.
>
> Minda Chen (3):
> dt-bindings: phy: Add StarFive JH7110 USB dt-binding
> usb: cdns3: add StarFive JH7110 USB glue layer
> dts: usb: add StarFive JH7110 USB dts configuration.

Unfortunately, this patchset hasn't really landed correctly.
Usually, in a series, patches are sent as replies to the cover letter.
Git's send-email will do this for you if you pass it multiple patches
and a cover letter (I do it by passing a directory, eg patches/foo/v1)

It appears that you have sent each patch separately, and to different
recipients, which makes this harder to review.
Please re-submit this with proper threading (and as v2 ideally, so that
Greg's bot doesn't complain).

Thanks,
Conor.

Attachment: signature.asc
Description: PGP signature