Re: [PATCH] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994

From: Konrad Dybcio
Date: Mon Mar 06 2023 - 05:46:29 EST




On 5.03.2023 13:24, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
>
> apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
>
> Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
It's funny how it was used in the dt in like 2016 but only added
to the driver in 2020..

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> index 16fd67c0bd1f..3580b209cd4a 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> @@ -40,6 +40,7 @@ properties:
> - qcom,rpm-msm8953
> - qcom,rpm-msm8974
> - qcom,rpm-msm8976
> + - qcom,rpm-msm8994
> - qcom,rpm-msm8996
> - qcom,rpm-msm8998
> - qcom,rpm-sdm660
> @@ -84,6 +85,7 @@ if:
> - qcom,rpm-msm8974
> - qcom,rpm-msm8976
> - qcom,rpm-msm8953
> + - qcom,rpm-msm8994
> then:
> properties:
> qcom,glink-channels: false