Re: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value

From: Fabio Estevam
Date: Mon Mar 06 2023 - 06:19:41 EST


On Mon, Mar 6, 2023 at 3:05 AM Ivan Bornyakov <i.bornyakov@xxxxxxxxxxx> wrote:
>
> If bus type is other than imx50_weim_devtype and have no child devices,
> variable 'ret' in function weim_parse_dt() will not be initialized, but
> will be used as branch condition and return value. Fix this by
> initializing 'ret' with 0.
>
> This was discovered with help of clang-analyzer, but the situation is
> quite possible in real life.
>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@xxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Please add a Fixes tag here.

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>