Re: [PATCH v2 14/18] x86/resctrl: Add helpers for system wide mon/alloc capable

From: James Morse
Date: Mon Mar 06 2023 - 06:34:26 EST


On 25/01/2023 07:16, Shaopeng Tan (Fujitsu) wrote:
>> resctrl reads rdt_alloc_capable or rdt_mon_capable to determine whether any
>> of the resources support the corresponding features.
>> resctrl also uses the static-keys that affect the architecture's context-switch
>> code to determine the same thing.
>>
>> This forces another architecture to have the same static-keys.
>>
>> As the static-key is enabled based on the capable flag, and none of the
>> filesystem uses of these are in the scheduler path, move the capable flags
>> behind helpers, and use these in the filesystem code instead of the static-key.
>>
>> After this change, only the architecture code manages and uses the static-keys
>> to ensure __resctrl_sched_in() does not need runtime checks.
>>
>> This avoids multiple architectures having to define the same static-keys.

> Reviewed-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxx>

Thanks!


James