Re: [PATCH] rcu: Fix rcu_torture_read ftrace event

[Mukesh Ojha]

On 3/6/2023 5:57 PM, Douglas RAILLARD wrote:
> From: Douglas Raillard <douglas.raillard@xxxxxxx>
>
> Fix the rcutorturename field so that its size is correctly reported in
> the text format embedded in trace.dat files. As it stands, it is
> reported as being of size 1:
>
>      field:char rcutorturename[8];   offset:8;       size:1; signed:0;
>
> Signed-off-by: Douglas Raillard <douglas.raillard@xxxxxxx>
> ---
>   include/trace/events/rcu.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h
> index 90b2fb0292cb..012fa0d171b2 100644
> --- a/include/trace/events/rcu.h
> +++ b/include/trace/events/rcu.h
> @@ -768,7 +768,7 @@ TRACE_EVENT_RCU(rcu_torture_read,
>   	TP_ARGS(rcutorturename, rhp, secs, c_old, c),
>   
>   	TP_STRUCT__entry(
> -		__field(char, rcutorturename[RCUTORTURENAME_LEN])
> +		__array(char, rcutorturename, RCUTORTURENAME_LEN)

Reviewed-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>

-Mukesh

>   		__field(struct rcu_head *, rhp)
>   		__field(unsigned long, secs)
>   		__field(unsigned long, c_old)