Re: [PATCH 02/11] arm64: dts: qcom: sm8250: drop incorrect Coresight funnel properties

[Konrad Dybcio]

On 5.03.2023 13:59, Krzysztof Kozlowski wrote:
> There is only one output port, thus out-ports should not have
> 'address/sice-cells' and unit addresses.  'reg-names' are also not
s/sice/size

> allowed by bindings.
> 
>   qrb5165-rb5.dtb: funnel@6042000: out-ports: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+'
>   qrb5165-rb5.dtb: funnel@6b04000: Unevaluated properties are not allowed ('reg-names' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 2f0e460acccd..88870d9e3348 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2799,11 +2799,7 @@ funnel@6042000 {
>  			clock-names = "apb_pclk";
>  
>  			out-ports {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -
> -				port@0 {
> -					reg = <0>;
> +				port {
>  					funnel_in1_out_funnel_merg: endpoint {
>  						remote-endpoint = <&funnel_merg_in_funnel_in1>;
>  					};
> @@ -2904,7 +2900,6 @@ funnel@6b04000 {
>  			arm,primecell-periphid = <0x000bb908>;
>  
>  			reg = <0 0x06b04000 0 0x1000>;
> -			reg-names = "funnel-base";
>  
>  			clocks = <&aoss_qmp>;
>  			clock-names = "apb_pclk";
> @@ -3220,9 +3215,6 @@ funnel@7810000 {
>  			clock-names = "apb_pclk";
>  
>  			out-ports {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -
>  				port {
>  					funnel_apss_merg_out_funnel_in1: endpoint {
>  					remote-endpoint = <&funnel_in1_in_funnel_apss_merg>;