Re: [PATCH] pinctrl: ocelot: Fix alt mode for ocelot

From: Linus Walleij
Date: Mon Mar 06 2023 - 09:22:01 EST


On Mon, Feb 6, 2023 at 9:37 PM Horatiu Vultur
<horatiu.vultur@xxxxxxxxxxxxx> wrote:

> In case the driver was trying to set an alternate mode for gpio
> 0 or 32 then the mode was not set correctly. The reason is that
> there is computation error inside the function ocelot_pinmux_set_mux
> because in this case it was trying to shift to left by -1.
> Fix this by actually shifting the function bits and not the position.
>
> Fixes: 4b36082e2e09 ("pinctrl: ocelot: fix pinmuxing for pins after 31")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>

Patch applied for fixes.

Yours,
Linus Walleij