Re: [PATCH v4 3/3] gpio: ws16c48: Migrate to the regmap API
From: Andy Shevchenko
Date: Mon Mar 06 2023 - 09:33:01 EST
On Mon, Mar 06, 2023 at 07:59:53AM -0500, William Breathitt Gray wrote:
...
> - raw_spinlock_t lock;
> + spinlock_t lock;
This is a regression.
That said, do we need a support of raw spin locks in the regmap IRQ?
...
> + u8 irq_mask[WS16C48_NUM_IRQS / WS16C48_NGPIO_PER_REG];
Can this be a bitmap? Or is it too over engineered with it?
--
With Best Regards,
Andy Shevchenko