Re: [PATCH 2/6] shmem: set shmem_writepage() variables early

From: Christian Brauner
Date: Mon Mar 06 2023 - 12:08:13 EST


On Thu, Mar 02, 2023 at 03:27:54PM -0800, Luis Chamberlain wrote:
> shmem_writepage() sets up variables typically used *after* a possible
> huge page split. However even if that does happen the address space
> mapping should not change, and the inode does not change either. So it
> should be safe to set that from the very beginning.
>
> This commit makes no functional changes.
>
> Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> ---

Looks good,
Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>