Re: [PATCH V5 01/15] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call
From: Mark Brown
Date: Mon Mar 06 2023 - 12:35:45 EST
On Mon, Mar 06, 2023 at 10:50:55PM +0530, Amit Kumar Mahapatra wrote:
> Supporting multi-cs in spi drivers would require the chip_select & cs_gpiod
> members of struct spi_device to be an array. But changing the type of these
> members to array would break the spi driver functionality. To make the
> transition smoother introduced four new APIs to get/set the
> spi->chip_select & spi->cs_gpiod and replaced all spi->chip_select and
> spi->cs_gpiod references with get or set API calls.
> While adding multi-cs support in further patches the chip_select & cs_gpiod
> members of the spi_device structure would be converted to arrays & the
> "idx" parameter of the APIs would be used as array index i.e.,
> spi->chip_select[idx] & spi->cs_gpiod[idx] respectively.
This doesn't apply against current code, there was a rework of the
mpc512x-psc driver. Please check and resend.
Attachment:
signature.asc
Description: PGP signature