Re: [PATCH] pstore: Revert pmsg_lock back to a normal mutex

From: John Stultz
Date: Mon Mar 06 2023 - 13:31:35 EST


On Thu, Mar 2, 2023 at 5:01 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Thu, 2 Mar 2023 16:56:13 -0500
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > Knowing that rcu_read_lock() keeps the tasks safe, I made the optimization
> > to only grab the spinlock (and disable interrupts) once, or whenever the
> > top waiter changes.
>
> v3 as I found that there were too places to test for top waiter that had to
> be removed:

Hey Steven,
Unfortunately previous versions didn't improve the situation for the
reporter, and this version is causing crashes (BUG at
kernel/locking/rtmutex_common.h:118!) for them.

I'm going to spend some time today to get a local reproducer so I can
tinker a bit here as well.

thanks
-john