Re: [PATCH 09/18] media: venus: hfi_venus: Fix version checks in venus_isr()

[Dikshita Agarwal]

On 3/7/2023 11:42 AM, Dikshita Agarwal wrote:
> On 2/28/2023 8:54 PM, Konrad Dybcio wrote:
> > IS_V6 was used there IS_IRIS2(_1) should have been and the !IS_V6
> > condition was only correct by luck and for now. Replace them both
> > with VPU version checks.
> >
> > Fixes: 24fcc0522d87 ("media: venus: hfi: Add 6xx interrupt support")
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > ---
> >   drivers/media/platform/qcom/venus/hfi_venus.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c 
> > b/drivers/media/platform/qcom/venus/hfi_venus.c
> > index 0d137e070407..ecfbac36de20 100644
> > --- a/drivers/media/platform/qcom/venus/hfi_venus.c
> > +++ b/drivers/media/platform/qcom/venus/hfi_venus.c
> > @@ -1136,7 +1136,7 @@ static irqreturn_t venus_isr(struct venus_core 
> > *core)
> >       wrapper_base = hdev->core->wrapper_base;
> >         status = readl(wrapper_base + WRAPPER_INTR_STATUS);
> > -    if (IS_V6(core)) {
> > +    if (IS_IRIS2(core) || IS_IRIS2_1(core)) {
> >           if (status & WRAPPER_INTR_STATUS_A2H_MASK ||
> >               status & WRAPPER_INTR_STATUS_A2HWD_MASK_V6 ||
> >               status & CPU_CS_SCIACMDARG0_INIT_IDLE_MSG_MASK)
> > @@ -1148,7 +1148,7 @@ static irqreturn_t venus_isr(struct venus_core 
> > *core)
> >               hdev->irq_status = status;
> >       }
> >       writel(1, cpu_cs_base + CPU_CS_A2HSOFTINTCLR);
> > -    if (!IS_V6(core))
> > +    if (!(IS_AR50_LITE(core) || IS_IRIS2(core) || IS_IRIS2_1(core)))
> >           writel(status, wrapper_base + WRAPPER_INTR_CLEAR);
> >         return IRQ_WAKE_THREAD;

this change looks good to me , once base register values are fixed in 
other patch.

reviewed-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>