Re: [PATCH v2 2/2] arm64: dts: amlogic: Add initial support for BPI-CM4 module with BPI-CM4IO baseboard

[Neil Armstrong]

On 06/03/2023 23:11, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Mon, Mar 6, 2023 at 9:31 AM Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote:
> > Add support for both the BananaPi BPI-CM4 module and the BananaPi
> > baseboard which is comnpatible with the RaspberryPi CM4IO baseboard.
> s/comnpatible/compatible/
>
> > The BananaPi BPI-CM4 module follows the CM4 specifications at [1],
> > but with a single HDMI port and a since DSI output.
> s/since/single/
>
> > The current CM4IO baseboard DT should work fine on the Raspberry CM4
> > baseboard and other derivatives baseboards, but proper DT should
> > be written for other baseboards.
> >
> > The split is done so it's easy to describe a new CM4 baseboard, enabling
> > only the necessary HW used on the baseboard.
> >
> > [1] https://datasheets.raspberrypi.com/cm4io/cm4io-datasheet.pdf
> >
> > Tested-by: Christian Hewitt <christianshewitt@xxxxxxxxx>
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> With the typos above fixed:

I'll fix those while applying


> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
>
> [...]
> > +&ext_mdio {
> > +       external_phy: ethernet-phy@0 {
> > +               /* Realtek RTL8211F (0x001cc916) */
> > +               reg = <0>;
> > +               max-speed = <1000>;
> > +
> > +               interrupt-parent = <&gpio_intc>;
> > +               /* MAC_INTR on GPIOZ_14 */
> > +               interrupts = <26 IRQ_TYPE_LEVEL_LOW>;
> It would be great to have the reset GPIO (GPIOZ_15) described as well.
> But this can be done in a follow-up patch.

I'll send a follow-up

> Best regards,
> Martin

Thanks !
Neil