Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU

From: AngeloGioacchino Del Regno
Date: Tue Mar 07 2023 - 04:52:14 EST


Il 07/03/23 09:05, Yong Wu ha scritto:
From: "Chengci.Xu" <chengci.xu@xxxxxxxxxxxx>

Add descriptions for mt8188 IOMMU which also use ARM Short-Descriptor
translation table format.

In mt8188, there are two smi-common HW and IOMMU, one is for vdo(video
output), the other is for vpp(video processing pipe). They connects
with different smi-larbs, then some setting(larbid_remap) is different.
Differentiate them with the compatible string.

Something like this:

IOMMU(VDO) IOMMU(VPP)
| |
SMI_COMMON_VDO SMI_COMMON_VPP

--------------- ----------------
| | ... | | ...
larb0 larb2 ... larb1 larb3 ...

We also have an IOMMU that is for infra master like PCIe.
And infra master don't have the larb and ports.

Signed-off-by: Chengci.Xu <chengci.xu@xxxxxxxxxxxx>
Reviewed-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Yong, if you're sending someone else's patch, you have to add your own signoff tag,
otherwise it's not going to be accepted.

With that fixed:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>