Re: [PATCH 02/20] pinctrl: amd: remove MODULE_LICENSE in non-modules
From: Linus Walleij
Date: Tue Mar 07 2023 - 08:11:39 EST
On Tue, Feb 28, 2023 at 2:02 PM Nick Alcock <nick.alcock@xxxxxxxxxx> wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@xxxxxxxxxx>
> Suggested-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Cc: linux-modules@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Hitomi Hasegawa <hasegawa-hitomi@xxxxxxxxxxx>
> Cc: Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>
> Cc: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
Can I just merge the 3 pinctrl patches to the pinctrl tree or are there
any dependencies?
Yours,
Linus Walleij