Re: [PATCH] rust: virtio: add virtio support

From: Gary Guo
Date: Tue Mar 07 2023 - 11:50:31 EST


On Tue, 7 Mar 2023 10:03:32 -0300
Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx> wrote:

> This patch adds virtIO support to the rust crate. This includes the
> capability to create a virtIO driver (through the module_virtio_driver
> macro and the respective Driver trait) as well as initial virtqueue
> support.
>
> A sample virtIO module is included for conveninence.
>
> Signed-off-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>
> ---
>
> Ok so this is my first Rust contribution here. It's part of a virtIO
> driver I was originally writing. Both the probing and the virtqueue
> support in here were confirmed as working in said prototype driver, and
> the pieces were picked separately into this patch.
>
> Feel free to point me to the best practices around Rust patch
> submission, as the C stuff like checkpatch etc probably does not apply
> yet. I did take care to run clippy though.

Hi Daniel,

This patch seems to be based on top the GitHub rust branch, not the
rust-next branch.

Best,
Gary