Re: [PATCH 2/2] watchdog: rt2880-wdt: prefer unsigned int over unsigned

[Guenter Roeck]

On Wed, Mar 01, 2023 at 07:55:10AM +0100, Sergio Paracuellos wrote:
> Instead of declare 'reg' variable in read and write operations as a bare
> 'unsigned' type prefer to declate it as 'unsigned int'.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/rt2880_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
> index e54737bcf939..4499ba0eb5ea 100644
> --- a/drivers/watchdog/rt2880_wdt.c
> +++ b/drivers/watchdog/rt2880_wdt.c
> @@ -54,12 +54,12 @@ MODULE_PARM_DESC(nowayout,
>  		"Watchdog cannot be stopped once started (default="
>  		__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
>  
> -static inline void rt_wdt_w32(void __iomem *base, unsigned reg, u32 val)
> +static inline void rt_wdt_w32(void __iomem *base, unsigned int reg, u32 val)
>  {
>  	iowrite32(val, base + reg);
>  }
>  
> -static inline u32 rt_wdt_r32(void __iomem *base, unsigned reg)
> +static inline u32 rt_wdt_r32(void __iomem *base, unsigned int reg)
>  {
>  	return ioread32(base + reg);
>  }