Re: [patch V2 4/4] net: dst: Switch to rcuref_t reference counting

From: Linus Torvalds
Date: Tue Mar 07 2023 - 13:03:34 EST


On Tue, Mar 7, 2023 at 4:57 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> - atomic_t __refcnt; /* 64-bit offset 64 */
> + rcuref_t __refcnt; /* 64-bit offset 64 */

> - atomic_t __refcnt; /* 32-bit offset 64 */
> + rcuref_t __refcnt; /* 32-bit offset 64 */

I assume any mis-use is caught by typechecking, but I'd be even
happier if you changed the name of the member when you fundamentally
change the use model for it (eg "__refcnt" -> "__rcuref" or
something).

Or was there some reason for not doing that?

Linus