Re: [PATCH net 1/2] net: dsa: mt7530: remove now incorrect comment regarding port 5

[Arınç ÜNAL]

On 8.03.2023 01:06, Vladimir Oltean wrote:
> On Wed, Mar 08, 2023 at 01:03:27AM +0300, arinc9.unal@xxxxxxxxx wrote:
> > From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> >
> > Remove now incorrect comment regarding port 5 as GMAC5. This is supposed to
> > be supported since commit 38f790a80560 ("net: dsa: mt7530: Add support for
> > port 5") under mt7530_setup_port5().
> >
> > Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5")
> > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> > ---
> >   drivers/net/dsa/mt7530.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> > index a508402c4ecb..b1a79460df0e 100644
> > --- a/drivers/net/dsa/mt7530.c
> > +++ b/drivers/net/dsa/mt7530.c
> > @@ -2201,7 +2201,7 @@ mt7530_setup(struct dsa_switch *ds)
> >   
> >   	mt7530_pll_setup(priv);
> >   
> > -	/* Enable Port 6 only; P5 as GMAC5 which currently is not supported */
> > +	/* Enable port 6 */
> >   	val = mt7530_read(priv, MT7530_MHWTRAP);
> >   	val &= ~MHWTRAP_P6_DIS & ~MHWTRAP_PHY_ACCESS;
> >   	val |= MHWTRAP_MANUAL;
> > --
> > 2.37.2
>
> It's best not to abuse the net.git tree with non-bugfix patches.

Fixing incorrect comments sounds bug fixing to me. Let's hear Jakub and 
David's thoughts.

Arınç