Re: [PATCH v2 02/21] of: Update of_device_get_modalias()

From: Rob Herring
Date: Tue Mar 07 2023 - 19:28:55 EST


On Tue, Mar 07, 2023 at 05:53:40PM +0100, Miquel Raynal wrote:
> This function only needs a "struct device_node" to work, but for
> convenience the author (and only user) of this helper did use a "struct
> device" and put it in device.c.
>
> Let's convert this helper to take a "struct device node" instead. This
> change asks for two additional changes: renaming it "of_modalias()"
> to fit the current naming, and moving it outside of device.c which will
> be done in a follow-up commit.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> drivers/of/device.c | 29 +++++++++++++++++------------
> 1 file changed, 17 insertions(+), 12 deletions(-)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>