Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings

[Jianhua Lu]

On Tue, Mar 07, 2023 at 11:22:35PM +0100, Linus Walleij wrote:
> On Mon, Feb 20, 2023 at 1:13 PM Jianhua Lu <lujianhua000@xxxxxxxxx> wrote:
> 
> > Novatek NT36523 is a display driver IC used to drive DSI panels.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx>
> > ---
> > Changes in v2:
> >   - Drop unnecessary description
> >   - dsi0 -> dsi
> >   - Correct indentation
> 
> I'd like Konrad and Neil to look at this before we merge it.
> 
> > +required:
> > +  - compatible
> > +  - reg
> > +  - vddio-supply
> > +  - vddpos-supply
> > +  - vddneg-supply
> 
> It appears vddpos and vddneg are not necessary on
> all variants, can they be made non-required?
It can be non-required, this panel's positive regulator and negative
regulator are supplied by backlight IC, the both regulator of Konrad's
NT36523W panel are supplied by secure firmware layer.
> 
> It is also possible to do some - if -construction of course
> based on the compatible, if we want to be fancy.
> 
> Yours,
> Linus Walleij