RE: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in

From: Luck, Tony
Date: Tue Mar 07 2023 - 19:37:59 EST


> I wonder if checkpatch could catch missing "inline" on static
> function definitions in header files?

Some casual use of grep shows that resctrl isn't the only offender.

There are many non-inline static functions in header files.

A few hundred scattered across core kernel code, drivers and most
architectures. E.g. a dozen in arch/x86/include/asm/floppy.h.

static irqreturn_t floppy_hardint(int irq, void *dev_id)
static void fd_disable_dma(void)
static int vdma_request_dma(unsigned int dmanr, const char *device_id)
static void vdma_nop(unsigned int dummy)
static int vdma_get_dma_residue(unsigned int dummy)
static int fd_request_irq(void)
static unsigned long dma_mem_alloc(unsigned long size)
static unsigned long vdma_mem_alloc(unsigned long size)
static void _fd_dma_mem_free(unsigned long addr, unsigned long size)
static void _fd_chose_dma_mode(char *addr, unsigned long size)
static int vdma_dma_setup(char *addr, unsigned long size, int mode, int io)
static int hard_dma_setup(char *addr, unsigned long size, int mode, int io)

-Tony