Re: [PATCH v2 1/5] gpio: loongson1: Convert to SPDX identifier

[Keguang Zhang]

On Wed, Mar 8, 2023 at 12:49 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> On Tue, Mar 7, 2023 at 3:25 AM Keguang Zhang <keguang.zhang@xxxxxxxxx> wrote:
> >
> > On Mon, Mar 6, 2023 at 5:29 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > >
> > > On Thu, Mar 2, 2023 at 1:52 PM Keguang Zhang <keguang.zhang@xxxxxxxxx> wrote:
> > > >
> > > > Use SPDX-License-Identifier instead of the license text and
> > > > update the author information.
> > > >
> > > > Signed-off-by: Keguang Zhang <keguang.zhang@xxxxxxxxx>
> > > > ---
> > > > V1 -> V2: Keep GPLv2, just convert to SPDX identifier
> > > > ---
> > > >  drivers/gpio/gpio-loongson1.c | 9 +++------
> > > >  1 file changed, 3 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c
> > > > index 5d90b3bc5a25..8862c9ea0d41 100644
> > > > --- a/drivers/gpio/gpio-loongson1.c
> > > > +++ b/drivers/gpio/gpio-loongson1.c
> > > > @@ -1,11 +1,8 @@
> > > > +// SPDX-License-Identifier: GPL-2.0-only
> > > >  /*
> > > >   * GPIO Driver for Loongson 1 SoC
> > > >   *
> > > > - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@xxxxxxxxx>
> > > > - *
> > > > - * This file is licensed under the terms of the GNU General Public
> > > > - * License version 2. This program is licensed "as is" without any
> > > > - * warranty of any kind, whether express or implied.
> > > > + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@xxxxxxxxx>
> > > >   */
> > > >
> > > >  #include <linux/module.h>
> > > > @@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = {
> > > >
> > > >  module_platform_driver(ls1x_gpio_driver);
> > > >
> > > > -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@xxxxxxxxx>");
> > >
> > > Why are you removing credits of the old author?
> > Kelvin Cheung and Keguang Zhang are the same person.
> > This change is to keep pace with the related entry of MAINTAINERS.
> >
>
> Even so - how could I have possibly known this? Please put it into the
> commit message, it's crucial information for this change.
>
Sure. I will amend the commit message.
In addition, should I update this patch only? Or the whole patch series?

> Bart



-- 
Best regards,

Kelvin Cheung