Re: [PATCH 2/6] dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365

From: Krzysztof Kozlowski
Date: Wed Mar 08 2023 - 05:33:20 EST


On 08/03/2023 11:30, Krzysztof Kozlowski wrote:
> On 07/03/2023 14:46, Alexandre Mergnat wrote:
>> Add binding description for mediatek,mt8365-smi-larb
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> index 5f4ac3609887..aee7f6cf1300 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> @@ -34,6 +34,10 @@ properties:
>> - const: mediatek,mt7623-smi-larb
>> - const: mediatek,mt2701-smi-larb
>>
>> + - items:
>> + - const: mediatek,mt8365-smi-larb
>> + - const: mediatek,mt8186-smi-larb
>
> You need to fix the allOf:if. It expects single item, so you need to add
> contains like for mt2701.

Wait, this was about common. LARB looks ok, but double check.

Best regards,
Krzysztof