Re: [PATCH 1/2] fork: allow CLONE_NEWTIME in clone3 flags

[Christian Brauner]

On Wed, Mar 08, 2023 at 11:51:26AM +0100, Tobias Klauser wrote:
> Currently, calling clone3() with CLONE_NEWTIME in clone_args->flags
> fails with -EINVAL. This is because CLONE_NEWTIME intersects with
> CSIGNAL. However, CSIGNAL was deprecated when clone3 was introduced in
> commit 7f192e3cd316 ("fork: add clone3"), allowing re-use of that part
> of clone flags.
> 
> Fix this by explicitly allowing CLONE_NEWTIME in clone3_args_valid. This
> is also in line with the respective check in check_unshare_flags which
> allow CLONE_NEWTIME for unshare().
> 
> Fixes: 769071ac9f20 ("ns: Introduce Time Namespace")
> Cc: Andrey Vagin <avagin@xxxxxxxxxx>
> Cc: Christian Brauner <brauner@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Tobias Klauser <tklauser@xxxxxxxxxx>
> ---

Oh I either forgot or missed that we use a CSIGNAL bit for
CLONE_NEWTIME. Looks good,

Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>