Re: [PATCH net-next v12 09/18] net: ethernet: mtk_eth_soc: Fix link status for none-SGMII modes

[Frank Wunderlich]

Am 8. März 2023 12:38:31 MEZ schrieb "Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx>:
>On Tue, Mar 07, 2023 at 03:54:11PM +0000, Daniel Golle wrote:
>> Link partner advertised link modes are not reported by the SerDes
>> hardware if not operating in SGMII mode. Hence we cannot use
>> phylink_mii_c22_pcs_decode_state() in this case.
>> Implement reporting link and an_complete only and use speed according to
>> the interface mode.
>> 
>> Fixes: 14a44ab0330d ("net: mtk_eth_soc: partially convert to phylink_pcs")
>> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
>
>This has been proven to work by Frank Wunderlich last October, so by
>making this change, you will be regressing his setup.

Hi

My tests were done with 1 kind of 1g fibre sfp as i only have these atm...have ordered some 2g5 rj54 ones,but don't have them yet. I'm not sure if they are working with/without sgmii (1000base-X) and if they have builtin phy.

Daniel have a lot more of different SFPs and some (especially 2g5) were not working after our pcs change.

>What are you testing against? Have you proven independently that the
>link partner is indeed sending a valid advertisement for the LPA
>register to be filled in?
>


regards Frank