[PATCH] lib: packing: remove MODULE_LICENSE in non-modules

From: Nick Alcock
Date: Wed Mar 08 2023 - 07:13:02 EST


Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@xxxxxxxxxx>
Suggested-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Cc: linux-modules@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: Hitomi Hasegawa <hasegawa-hitomi@xxxxxxxxxxx>
Cc: Vladimir Oltean <olteanv@xxxxxxxxx>
Cc: netdev@xxxxxxxxxxxxxxx
---
lib/packing.c | 1 -
1 file changed, 1 deletion(-)

(reposted to netdev as requested.)

diff --git a/lib/packing.c b/lib/packing.c
index a96169237ae66..3f656167c17e0 100644
--- a/lib/packing.c
+++ b/lib/packing.c
@@ -198,5 +198,4 @@ int packing(void *pbuf, u64 *uval, int startbit, int endbit, size_t pbuflen,
}
EXPORT_SYMBOL(packing);

-MODULE_LICENSE("GPL v2");
MODULE_DESCRIPTION("Generic bitfield packing and unpacking");
--
2.39.1.268.g9de2f9a303