Re: [PATCH 26/27] mfd: remove MODULE_LICENSE in non-modules

[Lee Jones]

On Wed, 08 Mar 2023, Nick Alcock wrote:

> On 3 Mar 2023, Lee Jones verbalised:
>
> > On Fri, 24 Feb 2023, Nick Alcock wrote:
> >
> >> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> >> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> >> are used to identify modules. As a consequence, uses of the macro
> >> in non-modules will cause modprobe to misidentify their containing
> >> object file as a module when it is not (false positives), and modprobe
> >> might succeed rather than failing with a suitable error message.
> >>
> >> So remove it in the files in this commit, none of which can be built as
> >> modules.
> >>
> >> Signed-off-by: Nick Alcock <nick.alcock@xxxxxxxxxx>
> >> Suggested-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> >> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> >> Cc: linux-modules@xxxxxxxxxxxxxxx
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> Cc: Hitomi Hasegawa <hasegawa-hitomi@xxxxxxxxxxx>
> >> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> >> Cc: Lee Jones <lee@xxxxxxxxxx>
> >> Cc: linux-omap@xxxxxxxxxxxxxxx
> >> ---
> >>  drivers/mfd/omap-usb-host.c | 1 -
> >>  drivers/mfd/omap-usb-tll.c  | 1 -
> >>  drivers/mfd/twl4030-audio.c | 1 -
> >>  drivers/mfd/twl6040.c       | 1 -
> >>  4 files changed, 4 deletions(-)
> >
> > Please adapt the subject line(s) to include the drivers changed.  It might
> > also make sense to separate out changes to cover one driver per patch.
>
> The subject line is automatically generated, and uses whatever
> subsystem prefix was most commonly used for all files touched in that
> subsystem, while not containing any prefixes *not* so touched.
>
> It's also automatically split up per-subsystem from a single big source
> commit that changes everything at once. I can split this bit more
> finely, but that means automated regeneration will be impossible, so
> it'll probably backslide if I ever have to regenerate it -- and I've had
> to regenerate this series a *lot*.
>
> In fact if I'd split this bit per driver, I'd probably have
> automatically got the subject line right as well -- but if the series as
> a whole were split up like that, it'd have had about 400 patches rather
> than 120, and got a lot of maintainers even more annoyed than they are
> now.
>
> For now, I'll split this one into four and mail it out again: coming
> shortly.

If you haven't sent it out already, 2 will be fine.

mfd: omap: ...
mfd: twl: ...

--
Lee Jones [李琼斯]