Re: [PATCH v2 1/4] firmware: qcom_scm: Clear download bit during reboot

From: Srinivas Kandagatla
Date: Wed Mar 08 2023 - 10:07:01 EST




On 01/03/2023 09:55, Mukesh Ojha wrote:
During normal restart of a system download bit should
be cleared irrespective of whether download mode is
set or not.
Looks like this is a fix, Fixes tag would help here.


--srini

Signed-off-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>
---
Changes in v2:
- No change

drivers/firmware/qcom_scm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index cdbfe54..51eb853 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -1418,8 +1418,7 @@ static int qcom_scm_probe(struct platform_device *pdev)
static void qcom_scm_shutdown(struct platform_device *pdev)
{
/* Clean shutdown, disable download mode to allow normal restart */
- if (download_mode)
- qcom_scm_set_download_mode(false);
+ qcom_scm_set_download_mode(false);
}
static const struct of_device_id qcom_scm_dt_match[] = {