Re: [PATCH v1 01/25] arm64: dts: colibri-imx8x: Prepare for qxp and dx variants

From: Philippe Schenker
Date: Wed Mar 08 2023 - 10:21:52 EST


On Wed, 2023-03-08 at 15:33 +0100, Krzysztof Kozlowski wrote:
> On 08/03/2023 13:52, Philippe Schenker wrote:
> > From: Philippe Schenker <philippe.schenker@xxxxxxxxxxx>
>
> Subject: Split? Or Rename? Because prepare is too vague.
>
> >
> > Toradex sells the Colibri iMX8X module in variants with the i.MX
> > 8QXP
> > and i.MX8DX SoC. Prepare for this by moving majority of stuff from
> > imx8qxp-colibri.dtsi into imx8x-colibri.dtsi.
> >
> > Remove DX from the model string.
> >
> > This commit intends no functional change.
> >
> > Signed-off-by: Philippe Schenker <philippe.schenker@xxxxxxxxxxx>
> > ---
> >
> >  .../dts/freescale/imx8qxp-colibri-eval-v3.dts |   4 +-
> >  .../boot/dts/freescale/imx8qxp-colibri.dtsi   | 590 +--------------
> > --
> >  ...val-v3.dtsi => imx8x-colibri-eval-v3.dtsi} |   0
> >  .../boot/dts/freescale/imx8x-colibri.dtsi     | 593
> > ++++++++++++++++++
>
> Use proper -B/-C/-M settings so copy will be detected. It's not
> possible
> to review it otherwise.

Thank you! I wasn't aware of these options. They look nice, will try to
make look it better in v2!
>
>
>
> Best regards,
> Krzysztof
>