Re: [PATCH 17/20] dt-bindings: pinctrl: mediatek: mt7986: fix patternProperties regex

From: Rob Herring
Date: Wed Mar 08 2023 - 16:15:20 EST


On Fri, Mar 03, 2023 at 03:28:46AM +0300, arinc9.unal@xxxxxxxxx wrote:
> From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
>
> Set second level patternProperties to '^.*mux.*$' and '^.*conf.*$' on
> mediatek,mt7986-pinctrl.yaml.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> ---
> .../devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml
> index 46b7228920ed..e937881210c5 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7986-pinctrl.yaml
> @@ -72,7 +72,7 @@ patternProperties:
> additionalProperties: false
>
> patternProperties:
> - '.*mux.*':
> + '^.*mux.*$':

These are equivalent (so is just 'mux', but that's ambiguous). Why are
we changing them? Ideally, we'd only have a wildcard on one end.

> type: object
> additionalProperties: false
> description: |
> @@ -256,7 +256,7 @@ patternProperties:
> items:
> enum: [wf_2g, wf_5g, wf_dbdc]
> maxItems: 3
> - '.*conf.*':
> + '^.*conf.*$':
> type: object
> additionalProperties: false
> description:
> --
> 2.37.2
>