Re: [PATCH 4/6] soc: samsung: pm_domains: Implement proper I/O operations
From: kernel test robot
Date: Wed Mar 08 2023 - 19:46:21 EST
Hi Sam,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on krzk/for-next]
[also build test WARNING on robh/for-next krzk-dt/for-next linus/master v6.3-rc1 next-20230308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sam-Protsenko/dt-bindings-power-pd-samsung-Add-Exynos850-support/20230309-071202
base: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git for-next
patch link: https://lore.kernel.org/r/20230308230931.27261-5-semen.protsenko%40linaro.org
patch subject: [PATCH 4/6] soc: samsung: pm_domains: Implement proper I/O operations
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230309/202303090824.TjEOnQJ8-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2dabd70f9264ef6cd044de6c3cbd3d83bfef8442
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sam-Protsenko/dt-bindings-power-pd-samsung-Add-Exynos850-support/20230309-071202
git checkout 2dabd70f9264ef6cd044de6c3cbd3d83bfef8442
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/soc/samsung/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Link: https://lore.kernel.org/oe-kbuild-all/202303090824.TjEOnQJ8-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/soc/samsung/pm_domains.c: In function 'exynos_pd_power':
>> drivers/soc/samsung/pm_domains.c:74:23: warning: variable 'base' set but not used [-Wunused-but-set-variable]
74 | void __iomem *base;
| ^~~~
vim +/base +74 drivers/soc/samsung/pm_domains.c
2dabd70f9264ef drivers/soc/samsung/pm_domains.c Sam Protsenko 2023-03-08 70
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 71 static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on)
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 72 {
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 73 struct exynos_pm_domain *pd;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 @74 void __iomem *base;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 75 u32 timeout, pwr;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 76 char *op;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 77
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 78 pd = container_of(domain, struct exynos_pm_domain, pd);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 79 base = pd->base;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 80
c028e175713698 drivers/soc/samsung/pm_domains.c Krzysztof Kozlowski 2016-05-10 81 pwr = power_on ? pd->local_pwr_cfg : 0;
2dabd70f9264ef drivers/soc/samsung/pm_domains.c Sam Protsenko 2023-03-08 82 exynos_pd_write_conf(pd, pwr);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 83
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 84 /* Wait max 1ms */
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 85 timeout = 10;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 86
2dabd70f9264ef drivers/soc/samsung/pm_domains.c Sam Protsenko 2023-03-08 87 while (exynos_pd_read_status(pd) != pwr) {
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 88 if (!timeout) {
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 89 op = (power_on) ? "enable" : "disable";
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 90 pr_err("Power domain %s %s failed\n", domain->name, op);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 91 return -ETIMEDOUT;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 92 }
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 93 timeout--;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 94 cpu_relax();
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 95 usleep_range(80, 100);
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 96 }
c760569d0e9c06 arch/arm/mach-exynos/pm_domains.c Prathyush K 2014-07-11 97
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 98 return 0;
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 99 }
91cfbd4ee0875f arch/arm/mach-exynos/pm_domains.c Thomas Abraham 2012-01-27 100
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests