Re: [PATCH v3 04/20] of: Move of_modalias() to module.c

From: Rob Herring
Date: Wed Mar 08 2023 - 21:22:07 EST


On Wed, Mar 08, 2023 at 04:31:44PM +0100, Miquel Raynal wrote:
> Create a specific .c file for OF related module handling.
> Move of_modalias() inside as a first step.
>
> The helper is exposed through of.h even though it is only used by core
> files because the users from device.c will soon be split into an OF-only
> helper in module.c as well as a device-oriented inline helper in
> of_device.h. Putting this helper in of_private.h would require to
> include of_private.h from of_device.h, which is not acceptable.
>
> Suggested-by: Rob Herring <robh+dt@xxxxxxxxxx>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> drivers/of/Makefile | 2 +-
> drivers/of/device.c | 37 -------------------------------------
> drivers/of/module.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/of.h | 9 +++++++++
> 4 files changed, 54 insertions(+), 38 deletions(-)
> create mode 100644 drivers/of/module.c

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>