Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly
From: Jakub Kicinski
Date: Wed Mar 08 2023 - 21:30:46 EST
On Tue, 7 Mar 2023 16:45:30 +0100 Simon Horman wrote:
> nit: This doesn't follow reverse xmas tree ordering - longest to shortest line.
> It's probably not worth respinning, but I expect the preferred
> approach is (*completely untested!*)
>
> ...
> struct pn533_out_arg arg;
> ...
>
> arg.phy = phy;
Let's do it this way.
And please make sure that the patch is based on top of the netdev/net
tree from git.kernel.org, looks like this version doesn't apply cleanly.