[PATCH] net: calxeda: fix race condition in xgmac_remove due to unfinshed work

From: Zheng Wang
Date: Wed Mar 08 2023 - 22:57:41 EST


In xgmac_probe, the priv->tx_timeout_work is bound with
xgmac_tx_timeout_work. In xgmac_remove, if there is an
unfinished work, there might be a race condition that
priv->base was written byte after iounmap it.

Fix it by finishing the work before cleanup.

Signed-off-by: Zheng Wang <zyytlz.wz@xxxxxxx>
---
drivers/net/ethernet/calxeda/xgmac.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
index f4f87dfa9687..94c3804001e3 100644
--- a/drivers/net/ethernet/calxeda/xgmac.c
+++ b/drivers/net/ethernet/calxeda/xgmac.c
@@ -1831,6 +1831,7 @@ static int xgmac_remove(struct platform_device *pdev)
/* Free the IRQ lines */
free_irq(ndev->irq, ndev);
free_irq(priv->pmt_irq, ndev);
+ cancel_work_sync(&priv->tx_timeout_work);

unregister_netdev(ndev);
netif_napi_del(&priv->napi);
--
2.25.1