RE: [PATCH v1 2/4] Revert "dt-bindings: mmc: Add bindings for Intel Thunder Bay SoC"

From: A, Rashmi
Date: Thu Mar 09 2023 - 01:43:33 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Tuesday, January 24, 2023 5:01 PM
> To: A, Rashmi <rashmi.a@xxxxxxxxx>; ulf.hansson@xxxxxxxxxx;
> michal.simek@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; kishon@xxxxxx; vkoul@xxxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx;
> mgross@xxxxxxxxxxxxxxx
> Cc: kris.pan@xxxxxxxxxxxxxxx; Hunter, Adrian <adrian.hunter@xxxxxxxxx>;
> Vaidya, Mahesh R <mahesh.r.vaidya@xxxxxxxxx>; Srikandan, Nandhini
> <nandhini.srikandan@xxxxxxxxx>; Itha, Vasavi V <vasavi.v.itha@xxxxxxxxx>;
> Demakkanavar, Kenchappa <kenchappa.demakkanavar@xxxxxxxxx>; Zhou,
> Furong <furong.zhou@xxxxxxxxx>; Sangannavar, Mallikarjunappa
> <mallikarjunappa.sangannavar@xxxxxxxxx>
> Subject: Re: [PATCH v1 2/4] Revert "dt-bindings: mmc: Add bindings for Intel
> Thunder Bay SoC"
>
> On 24/01/2023 06:44, rashmi.a@xxxxxxxxx wrote:
> > From: "A, Rashmi" <rashmi.a@xxxxxxxxx>
> >
> > This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on recent
> Linux kernel.
Acknowledged

>
> >
> > Revert Thunder Bay specific code as the product got cancelled and
> > there are no end customers.
> >
> > Signed-off-by: A, Rashmi <rashmi.a@xxxxxxxxx>
> > Reviewed-by: Hunter, Adrian <adrian.hunter@xxxxxxxxx>wq
>
> Stray characters.
Acknowledged

>
> > ---
> > .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25
> > -------------------
> > 1 file changed, 25 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> > b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> > index 4053de758db6..0d5d21dd30bb 100644
> > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> > @@ -88,12 +88,6 @@ properties:
> > description:
> > For this device it is strongly suggested to include
> > arasan,soc-ctl-syscon.
> > - - items:
> > - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY
> > - - const: arasan,sdhci-5.1
>
> Instead should be made rather deprecated, unless you are sure there is no single
> person in the world using the bindings (e.g. with BSD or bootloader)?
May I know what has to be done in order to deprecate the complete patchset?
We have a proposal to club together the 2 driver patches and 2 dt binding patches and send out new patchset containing only 2 revert patches.
Patch 1 - revert dt-bindings patch
Revert "dt-bindings: mmc: Add bindings for Intel Thunder Bay SoC" & Revert "dt-bindings: phy: intel: Add Thunder Bay eMMC PHY bindings"
Patch 2 - revert driver patch
"Revert mmc: sdhci-of-arasan: Add intel Thunder Bay SOC support to the arasan eMMC driver" & "Revert phy: intel: Add Thunder Bay eMMC PHY support"

>
>
>
> Best regards,
> Krzysztof


-Regards
Rashmi