Re: erofs: use wrapper i_blocksize() in erofs_file_read_iter()

[Gao Xiang]

On 2023/3/9 15:37, Yue Hu wrote:
> On Thu,  9 Mar 2023 15:15:15 +0800
> Yangtao Li <frank.li@xxxxxxxx> wrote:
>
> > > @@ -380,7 +380,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
> > > 		if (bdev)
> > > 			blksize_mask = bdev_logical_block_size(bdev) - 1;
> > > 		else
> > > -			blksize_mask = (1 << inode->i_blkbits) - 1;
> > > +			blksize_mask = i_blocksize(inode) - 1;
> >
> > Since the mask is to be obtained here, is it more appropriate to use GENMASK(inode->i_blkbits - 1, 0)?
>
> It should be another change independently to this patch. rt?

I'd suggest that keep to use (i_blocksize(inode) - 1) here, for example:

https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/tree/fs/gfs2/bmap.c#n963

Thanks,
Gao Xiang

> > Thx,
> > Yangtao