Re: [PATCH v4] ASoC: cs35l41: Steam Deck Shared boost properties quirk

[Krzysztof Kozlowski]

On 09/03/2023 12:19, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 12:17:35PM +0100, Krzysztof Kozlowski wrote:
>> On 09/03/2023 12:04, Mark Brown wrote:
>>> On Thu, Mar 09, 2023 at 11:42:42AM +0100, Krzysztof Kozlowski wrote:
> 
>>>> You are now changing ABI and adding undocumented properties.
> 
>>> This is newly added code, changes are fine.
> 
>> OK, for the ABI code, but not for the undocumented properties. Commit
>> does not explain that.
> 
> It does, it says that it's adding support for the properties used in the
> firmware on existing Steam Decks.  Those aren't even DT systems.

For some reason DT is cced...

The code unfortunately will allow to put them into DT and next time
people will use it as an argument to document in the binding ("because
driver already has them"). I heard this argument already many times.

Document then that these are not DT properties.

Best regards,
Krzysztof