Re: [PATCH 1/6] crypto: qat - drop redundant adf_enable_aer()

[Giovanni Cabiddu]

On Tue, Mar 07, 2023 at 10:19:42AM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> 
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
> 
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
> 
> Note that this only controls ERR_* Messages from the device.  An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>
> Cc: qat-linux@xxxxxxxxx
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@xxxxxxxxx>

Reviewed and tried on c62x and 4xxx.
Just a note. This patch will not apply cleanly after [1] is applied.

[1] https://patchwork.kernel.org/project/linux-crypto/patch/20230227205545.5796-2-shashank.gupta@xxxxxxxxx/

Regards,

-- 
Giovanni