Re: [PATCH v1 2/4] Revert "dt-bindings: mmc: Add bindings for Intel Thunder Bay SoC"

From: Adrian Hunter
Date: Thu Mar 09 2023 - 09:16:47 EST


On 24/01/23 13:31, Krzysztof Kozlowski wrote:
> On 24/01/2023 06:44, rashmi.a@xxxxxxxxx wrote:
>> From: "A, Rashmi" <rashmi.a@xxxxxxxxx>
>>
>> This reverts commit ab991c05c42853f0b6110022db9bf30fcc6323dd.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
>>
>> Revert Thunder Bay specific code as the product got cancelled
>> and there are no end customers.
>>
>> Signed-off-by: A, Rashmi <rashmi.a@xxxxxxxxx>
>> Reviewed-by: Hunter, Adrian <adrian.hunter@xxxxxxxxx>wq
>
> Stray characters.
>
>> ---
>> .../devicetree/bindings/mmc/arasan,sdhci.yaml | 25 -------------------
>> 1 file changed, 25 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> index 4053de758db6..0d5d21dd30bb 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
>> @@ -88,12 +88,6 @@ properties:
>> description:
>> For this device it is strongly suggested to include
>> arasan,soc-ctl-syscon.
>> - - items:
>> - - const: intel,thunderbay-sdhci-5.1 # Intel Thunder Bay eMMC PHY
>> - - const: arasan,sdhci-5.1
>
> Instead should be made rather deprecated, unless you are sure there is
> no single person in the world using the bindings (e.g. with BSD or
> bootloader)?

I am sorry but this is not clear to me. As I understand it,
the hardware was never released, so the binding serves no
purpose. Should it be removed or "deprecated"?