Re: [PATCH 1/2] erofs: Revert "erofs: fix kvcalloc() misuse with __GFP_NOFAIL"

[Chao Yu]

On 2023/3/9 13:31, Gao Xiang wrote:
> Let's revert commit 12724ba38992 ("erofs: fix kvcalloc() misuse with
> __GFP_NOFAIL") since kvmalloc() already supports __GFP_NOFAIL in commit
> a421ef303008 ("mm: allow !GFP_KERNEL allocations for kvmalloc").  So
> the original fix was wrong.
>
> Actually there was some issue as [1] discussed, so before that mm fix
> is landed, the warn could still happen but applying this commit first
> will cause less.
>
> [1] https://lore.kernel.org/r/20230305053035.1911-1-hsiangkao@xxxxxxxxxxxxxxxxx
> Fixes: 12724ba38992 ("erofs: fix kvcalloc() misuse with __GFP_NOFAIL")
> Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Reviewed-by: Chao Yu <chao@xxxxxxxxxx>

Thanks,