Re: [PATCH v1] gpio: loongson: fixup the warning about OF_GPIO direct dependencies

From: Bartosz Golaszewski
Date: Thu Mar 09 2023 - 09:53:08 EST


On Thu, Mar 9, 2023 at 12:14 PM Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> wrote:
>
> WARNING: unmet direct dependencies detected for OF_GPIO
> Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
> Selected by [y]:
> - GPIO_LOONGSON_64BIT [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (LOONGARCH || COMPILE_TEST [=y])
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Link: https://lore.kernel.org/oe-kbuild-all/202303091728.UUe6LWye-lkp@xxxxxxxxx
> ---
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 94051fb59043d..c0d6254797800 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -384,7 +384,7 @@ config GPIO_LOONGSON
> config GPIO_LOONGSON_64BIT
> tristate "Loongson 64 bit GPIO support"
> depends on LOONGARCH || COMPILE_TEST
> - select OF_GPIO
> + depends on OF_GPIO
> select GPIO_GENERIC
> help
> Say yes here to support the GPIO functionality of a number of
> --
> 2.31.1
>

Thanks for the quick fix, applied.

Bart