Re: [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>

From: Andy Shevchenko
Date: Thu Mar 09 2023 - 10:07:14 EST


On Thu, Mar 09, 2023 at 03:08:47PM +0100, Linus Walleij wrote:
> On Thu, Mar 9, 2023 at 2:52 PM Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>
> > shx3_defconfig:
> >
> > arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’:
> > arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’
> > 246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i;
> > | ^
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>
> > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@xxxxxxxxxxxxxx
> > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> This is fallout from cleanups in Bartosz GPIO tree, so it will be applied there.
> Make sure Bartosz gets the patch (now on To:)
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks, as for previous patch on the same topic, I am collecting this one.

I will sent a new PR to Bart including all fixes, but I would wait one or a
couple of weeks before doing that. Meanwhile these will be in Linux Next.

--
With Best Regards,
Andy Shevchenko