Re: [PATCH v4] scsi: ufs: core: Add trace event for MCQ

From: Bart Van Assche
Date: Thu Mar 09 2023 - 10:46:04 EST


On 3/8/23 18:44, Ziqi Chen wrote:
Thanks for you suggestion. But the member hwq->id is an Unsigned integer. if you want to identify SDB mode and MCQ mode,  using "0" is enough, Or how about add string such as below?

ufshcd_command: MCQ: complete_rsp: 1d84000.ufshc: tag: 14, DB: 0x0, size: 32768, IS: 0, LBA: 5979448,opcode: 0x2a (WRITE_10),group_id: 0x0, hqid: 2

Hi Ziqi,

Since 0 is a valid queue ID using 0 to identify the legacy command submission mechanism is ambiguous.

Thanks,

Bart.