Re: [PATCH] nfc: pn533: initialize struct pn533_out_arg properly

[Simon Horman]

On Thu, Mar 09, 2023 at 07:10:25PM +0300, Fedor Pchelkin wrote:
> On Tue, Mar 07, 2023 at 04:45:30PM +0100, Simon Horman wrote:
> > 
> > nit: This doesn't follow reverse xmas tree ordering - longest to shortest line.
> >      It's probably not worth respinning, but I expect the preferred
> >      approach is (*completely untested!*)
> > 
> > 	...
> > 	struct pn533_out_arg arg;
> > 	...
> > 
> > 	arg.phy = phy;
> > 
> 
> That is much prettier, thanks for advice!
> 
> BTW, is reverse xmas tree ordering considered to be a general
> recommendation for all new kernel patches?

I think that the situation is that some subsystem maintainers require it,
while other's do not. So no.