Re: [PATCH] LoongArch: Provide kernel fpu functions

[Christoph Hellwig]

On Mon, Mar 06, 2023 at 09:55:27AM +0800, Huacai Chen wrote:
> On Sun, Mar 5, 2023 at 9:28 PM Xi Ruoyao <xry111@xxxxxxxxxxx> wrote:
> >
> > On Sun, 2023-03-05 at 20:18 +0800, Huacai Chen wrote:
> > > > Might be good to provide some explanation in the commit message as to
> > > > why the pair of helpers should be GPL-only. Do they touch state buried
> > > > deep enough to make any downstream user a "derivative work"? Or are the
> > > > annotation inspired by arch/x86?
> > > Yes, just inspired by arch/x86, and I don't think these symbols should
> > > be used by non-GPL modules.
> >
> > Hmm, what if one of your partners wish to provide a proprietary GPU
> > driver using the FPU like this way?  As a FLOSS developer I'd say "don't
> > do that, make your driver GPL".  But for Loongson there may be a
> > commercial issue.
> So use EXPORT_SYMBOL can make life easier?

No.  All in-kernel FPU helpers must be EXPORT_SYMBOL_GPL.