Re: [RESEND PATCH v2] sched/debug: Put sched/domains files under the verbose flag

[Phil Auld]

On Thu, Mar 09, 2023 at 03:44:45PM +0100 Greg KH wrote:
> On Fri, Mar 03, 2023 at 01:37:54PM -0500, Phil Auld wrote:
> > The debug files under sched/domains can take a long time to regenerate,
> > especially when updates are done one at a time. Move these files under
> > the sched verbose debug flag. Allow changes to verbose to trigger
> > generation of the files. This lets a user batch the updates but still
> > have the information available.  The detailed topology printk messages
> > are also under verbose.
> > 
> > Discussion that lead to this approach can be found in the link below.
> > 
> > Simplified code to maintain use of debugfs bool routines suggested by
> > Michael Ellerman <mpe@xxxxxxxxxxxxxx>.
> > 
> > Signed-off-by: Phil Auld <pauld@xxxxxxxxxx>
> > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Valentin Schneider <vschneid@xxxxxxxxxx>
> > Reviewed-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> > Tested-by: Vishal Chourasia <vishalc@xxxxxxxxxxxxxxxxxx>
> > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> > Cc: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> > Cc: Valentin Schneider <vschneid@xxxxxxxxxx>
> > Cc: Vishal Chourasia <vishalc@xxxxxxxxxxxxxxxxxx>
> > Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> > Link: https://lore.kernel.org/all/Y01UWQL2y2r69sBX@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> > ---
> > 
> >  v2: fix comment typo and use cpumask_empty()
> > 
> >  kernel/sched/debug.c | 52 +++++++++++++++++++++++++++++++++++++++++---
> >  1 file changed, 49 insertions(+), 3 deletions(-)
> 
> As no one has picked this up yet, and it is really a debugfs issue, I'll
> queue this up in the driver-core tree (which takes debugfs changes) for
> 6.4-rc1 unless someone screams.
>

Thanks Greg!


> thanks,
> 
> greg k-h
> 

--