Re: [PATCH 19/20] dt-bindings: pinctrl: mediatek: mt7620: split binding

[Arınç ÜNAL]

On 9.03.2023 12:54, Krzysztof Kozlowski wrote:
> On 03/03/2023 01:28, arinc9.unal@xxxxxxxxx wrote:
> > From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> >
> > The MT7628 and MT7688 SoCs contain different pin muxing information,
> > therefore, should be split. This can be done now that there are compatible
> > strings to distinguish them from other SoCs.
> >
> > Split the schema out to mediatek,mt76x8-pinctrl.yaml.
> >
> > Remove mediatek,mt76x8-pinctrl from mt7620.
> >
> > Deprecate ralink,mt7620-pinctrl. The reason is, the DTs for mt76x8 which
> > use this string will incorrectly match the pin muxing information for
> > mt7620. There's a new string, mediatek,mt7620-pinctrl, which makes the
> > deprecation possible.
> >
> > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> > ---
> >   .../pinctrl/mediatek,mt7620-pinctrl.yaml      | 380 +--------------
> >   .../pinctrl/mediatek,mt76x8-pinctrl.yaml      | 450 ++++++++++++++++++
> >   2 files changed, 459 insertions(+), 371 deletions(-)
> >   create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt76x8-pinctrl.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> > index 11530b29d52b..38b71c74b9a0 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> > @@ -11,16 +11,13 @@ maintainers:
> >     - Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> >   
> >   description: |
> > -  MediaTek MT7620 pin controller for MT7620, MT7628 and MT7688 SoCs.
> > +  MediaTek MT7620 pin controller for MT7620 SoC.
> >     The pin controller can only set the muxing of pin groups. Muxing individual
> >     pins is not supported. There is no pinconf support.
> >   
> >   properties:
> >     compatible:
> > -    enum:
> > -      - mediatek,mt7620-pinctrl
> > -      - mediatek,mt76x8-pinctrl
> > -      - ralink,mt7620-pinctrl
>
> I see removal, not deprecation.

I thought deprecation meant removing a string with explanation on the 
patch log, as I remember from my conversation with you and Rob on this 
patch series.

https://lore.kernel.org/linux-devicetree/87c9bf7e-f290-7d38-0844-7a7243688f5a@xxxxxxxxxx/

I won't have to deprecate this now that we straightened things out but 
I'd like to know the proper way to deprecate compatible strings regardless.

Arınç