Re: [PATCH] block: don't embed integrity_kobj into gendisk

From: Thomas Weißschuh
Date: Thu Mar 09 2023 - 18:26:59 EST


On Thu, Mar 09, 2023 at 10:46:50PM +0100, Mirsad Goran Todorovac wrote:
> On 09. 03. 2023. 22:23, Thomas Weißschuh wrote:
>
> Very well, but who then destroys the cache crated here:
>
> security/integrity/iint.c:177-179
> > 177 iint_cache =
> > 178 kmem_cache_create("iint_cache", sizeof(struct integrity_iint_cache),
> > 179 0, SLAB_PANIC, init_once);
>
> I assumed that it must have been done from iint.c because iint_cache is
> static?

It doesn't seem like anything destroys this cache.

I'm not sure this is a problem though as iint.c can not be built as module.

At least it's not a problem with kobjects as those are not used here.

> BTW, moving check for !ktype->release to kobject_init() is great for it
> might make such problems noticed in dmesg, rather than taking screenshots.
>
> Regards,