RE: [PATCH 2/2] ASoC: dt-bindings: max98363: add soundwire amplifier driver

From: Lee, RyanS
Date: Thu Mar 09 2023 - 20:33:07 EST


> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Thursday, February 23, 2023 8:30 PM
> To: “Ryan <ryan.lee.analog@xxxxxxxxx>
> Cc: Lee, RyanS <RyanS.Lee@xxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx;
> pierre-louis.bossart@xxxxxxxxxxxxxxx; rf@xxxxxxxxxxxxxxxxxxxxx;
> wangweidong.a@xxxxxxxxxx; broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> povik+lin@xxxxxxxxxxx; perex@xxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> james.schulman@xxxxxxxxxx; lgirdwood@xxxxxxxxx; shumingf@xxxxxxxxxxx;
> tiwai@xxxxxxxx; ajye_huang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> ckeepax@xxxxxxxxxxxxxxxxxxxxx; herve.codina@xxxxxxxxxxx;
> krzysztof.kozlowski@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> flatmax@xxxxxxxxxxx
> Subject: Re: [PATCH 2/2] ASoC: dt-bindings: max98363: add soundwire
> amplifier driver
>
> [External]
>
>
> On Thu, 23 Feb 2023 17:08:14 -0800, “Ryan wrote:
> > From: Ryan Lee <ryans.lee@xxxxxxxxxx>
> >
> > This patch adds dt-bindings information for Analog Devices MAX98363
> > SoundWire Amplifier.
> >
> > Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxx>
> > ---
> > .../bindings/sound/adi,max98363.yaml | 53 +++++++++++++++++++
> > 1 file changed, 53 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/sound/adi,max98363.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error:
> Documentation/devicetree/bindings/sound/adi,max98363.example.dts:29.3
> -30.1 syntax error FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:434:
> Documentation/devicetree/bindings/sound/adi,max98363.example.dtb]
> Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1508: dt_binding_check] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/devicet
> ree-bindings/patch/20230224010814.504016-2-
> ryan.lee.analog@gmail.com__;!!A3Ni8CS0y2Y!7mTDqdmHdbwbp5Dxm5RJ60i
> TMlM6mf6W3Z9PQwXMB92aBcnAkwZODw5olBaFKtmbimORUpXmQ2j2$
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade

Thank you. I did run the 'dt_binding_check' build, but some module was not installed.
I shall modify the error and submit it again.

>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.